Use runtime formatting for ILLink #116941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-Tools-ILLink
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ILLink codebase to use runtime formatting rules by removing the ILLink .editorconfig and running dotnet format over various projects. The key changes consist of converting tab-based indentation to space-based formatting, reformatting block constructs with consistent brace placement, and standardizing spacing across the code.
Reviewed Changes
Copilot reviewed 175 out of 1660 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WarningSuppressionWriter.cs | Reformatted control flow and block braces for runtime consistency |
| UnconditionalSuppressMessageAttributeState.cs | Updated indentation and spacing in conditionals and loops |
| TypeReferenceWalker.cs | Reformatted loops and conditionals to adhere to new formatting guidelines |
| (and many more) | Similar formatting adjustments and whitespace cleanups across the codebase |
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
Some of the .editorconfig changes weren't automatically fixed by dotnet format. Add back those rules for now so that this builds.
This was referenced Jun 24, 2025
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to use copilot to make some ILLink changes and it was having trouble with the ILLink formatting conventions (in particular it was having trouble using tabs for indentation), so it seems like a good time to move over to the runtime formatting rules.
I deleted the ILLink .editorconfig and ran
dotnet formatover the various ILLink projects.edit: I added back the .editorconfig with a few settings that weren't fixed automatically by 'dotnet format' but are
enforced by the build.