Remove obsolete native AOT test special casing #116958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete native AOT special casing in several event tracing tests by unifying event count expectations and adjusting the invocation of the test runner API. Key changes include:
- Eliminating separate dictionaries and conditional enableRundown flags for NativeAOT.
- Updating calls to IpcTraceTest.RunAndValidateEventCounts to use a unified parameter set.
- Removing platform-specific branching in event listener tests.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/tracing/eventpipe/providervalidation/providervalidation.cs | Removed native AOT special casing for event count dictionaries and enableRundown flag. |
| src/tests/tracing/eventpipe/gcdump/gcdump.cs | Eliminated native AOT enableRundown flag parameter from the test runner call. |
| src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs | Unified event counts and removed native AOT specific conditions. |
| src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs | Unified event counts and removed native AOT specific conditions. |
| src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs | Unified event counts and removed obsolete native AOT handling. |
| src/tests/tracing/eventlistener/EventListenerThreadPool.cs | Removed conditional native AOT branch for threadpool event waiting. |
Comments suppressed due to low confidence (6)
src/tests/tracing/eventpipe/providervalidation/providervalidation.cs:37
- The removal of the native AOT specific enableRundown flag is clear, but please confirm that the unified _expectedEventCounts dictionary provides adequate coverage for both NativeAOT and CoreCLR scenarios.
new EventPipeProvider("Microsoft-DotNETCore-SampleProfiler", EventLevel.Verbose)
src/tests/tracing/eventpipe/gcdump/gcdump.cs:44
- The native AOT flag removal in favor of a parameterless call to RunAndValidateEventCounts should be verified to not affect the expected behavior of GC dump tests across different runtimes.
new EventPipeProvider("Microsoft-Windows-DotNETRuntime", eventLevel: EventLevel.Verbose, keywords: (long)ClrTraceEventParser.Keywords.GCHeapSnapshot)
src/tests/tracing/eventpipe/eventsvalidation/GCFinalizers.cs:23
- Removing the conditional enableRundown flag and unifying the _expectedEventCounts dictionary simplifies the test logic; please ensure that the consolidated event count configuration meets the testing requirements for all environments.
new EventPipeProvider("Microsoft-Windows-DotNETRuntime", EventLevel.Informational, 0b1)
src/tests/tracing/eventpipe/eventsvalidation/GCEvents.cs:23
- The removal of native AOT-based conditional logic should be double checked against the expected event outcomes to ensure that differences in runtime behavior are appropriately handled.
new EventPipeProvider("Microsoft-Windows-DotNETRuntime", EventLevel.Informational, 0b1)
src/tests/tracing/eventpipe/eventsvalidation/ExceptionThrown_V1.cs:22
- With the obsolete native AOT special casing removed, verify that the unified approach to event count expectations in ExceptionThrown tests still yields consistent and correct test results.
new EventPipeProvider("Microsoft-Windows-DotNETRuntime", EventLevel.Warning, 0b1000_0000_0000_0000)
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cc @dotnet/ilc-contrib