[APX] Make sure disasmembler log correct EGPR size when OSIZE is 32b. #116988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the disasmembler where the incorrect size suffix was logged when OSIZE is 32b by updating the register bounds check.
- Changed the register upper bound check from REG_R15 to REG_R31
- Adjusted the condition to ensure proper handling of 32b cases
Comments suppressed due to low confidence (1)
src/coreclr/jit/emitxarch.cpp:11798
- Ensure REG_R31 is defined and valid on all target platforms where this code executes; this update is essential for logging the correct EGPR size when OSIZE is 32b.
if (reg > REG_R31)
|
@dotnet/intel for review, thanks! |
tannergooding
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disasmembler was not printing the size suffix when OSIZE is 32b, this PR fixes the issue.