[cDAC] Change runtime-diagnostics pipeline trigger #117018
Conversation
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
|
I had thought we wanted this to be manually triggered only? |
|
It looks like @jkoritzinsky 's intent in #114718 was to have it trigger whenever cDAC files were modified in a PR. I think that behavior would be useful as well. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the runtime-diagnostics pipeline trigger so that it runs automatically on PRs.
Key changes:
- Updated the include patterns in the runtime-diagnostics YAML file.
- Added a wildcard ("*") pattern to trigger the pipeline on all file changes.
max-charlamb
changed the title
max-charlamb
changed the title
| - '/src/coreclr/**' | ||
| - '/src/native/**' | ||
| - eng/pipelines/** | ||
| - src/native/managed/cdac/** |
There was a problem hiding this comment.
Would we not want this pipeline to run for PRs that are changing EventPipe logic /src/native/eventpipe?
There was a problem hiding this comment.
I'm not sure. Currently this pipeline has mostly been used for testing the cDAC, but it is running all (?) of the diagnostic unit tests. If it would be useful or eventpipe I don't see why it shouldn't be added.
Do note, that this pipeline is not incorporated into build analysis and I don't think it will prevent merging.
There was a problem hiding this comment.
From the intent of the PR that added this pipeline, it feels like we should include all paths that impact diagnostics. It does seem underutilized, probably because it needs to be manually triggered.
There was a problem hiding this comment.
If we don't mind the extra CI cost, it seems reasonable to have it on the existing subsets.
There was a problem hiding this comment.
If it is costly, we can keep it to your subsets for now, and expand it more when it makes sense.
Previously the runtime-diagnostics pipeline was not running on any PRs automatically due to an overridden ADO.
Modified ADO setting to let PR runs occur, but narrowing subset of files pipeline runs on to:
eng/pipelines/**src/native/managed/cdac/**src/coreclr/debug/runtimeinfo/**(where the datadescriptors are defined)