ML-KEM: MLKemCng and CNG properties #117060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
bartonjs
reviewed
Jun 26, 2025
src/libraries/Common/tests/System/Security/Cryptography/MLKemCngTests.Windows.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jun 26, 2025
src/libraries/Microsoft.Bcl.Cryptography/src/System/Security/Cryptography/NetStandardShims.cs
Outdated
Show resolved
Hide resolved
src/libraries/Common/tests/System/Security/Cryptography/MLKemCngTests.Windows.cs
Show resolved
Hide resolved
This was referenced Jun 26, 2025
bartonjs
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds primitive functionality for
MLKemCngin System.Security.Cryptography and Microsoft.Bcl.Cryptography.Only basic encapsulation, decapsulation, and key operations are supported. Windows' ML-KEM "ncrypt" functionality is incomplete.
X.509 / PKCS#12 support for ML-KEM certificates is missing.
NCryptExportKeycannot perform a PKCS#8 export of an ML-KEM key handle. This means that we cannot perform encrypted exports. So key export functionality is currently limited to plaintext-exportable CNG keys.The managed PKCS#8 encoder that is used for MLKemImplementation is used by MLKemCng, for now, since we are able to export the blobs. As Windows' implementation progresses
Contributes to #116304