Add equality to SlhDsaAlgorithm #117069
Merged
Add equality to SlhDsaAlgorithm #117069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds equality support for SlhDsaAlgorithm by implementing IEquatable and providing overrides for Equals, GetHashCode, ToString, and the equality operators. It also introduces comprehensive unit tests to validate the equality behavior for various SlhDsaAlgorithm instances.
- Implements equality members in both reference and implementation (common) projects.
- Updates test cases to verify that equality, inequality, hash codes, and string representations function as expected.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs | Adds equality members to the SlhDsaAlgorithm ref class. |
| src/libraries/Common/tests/System/Security/Cryptography/AlgorithmImplementations/SlhDsa/SlhDsaAlgorithmTests.cs | Introduces new tests to verify equality and inequality operators as well as GetHashCode and ToString implementations. |
| src/libraries/Common/src/System/Security/Cryptography/SlhDsaAlgorithm.cs | Implements IEquatable with equality members based solely on the algorithm Name. |
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
PranavSenthilnathan
approved these changes
Jun 26, 2025
bartonjs
approved these changes
Jun 26, 2025
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same pull request as #116750 except for SLH-DSA.