cleanup memory after UnflushedBytes_HandlesLargeValues test #117115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
This was referenced Jun 28, 2025
teo-tsirpanis
added
area-System.IO.Pipelines
and removed
needs-area-label
akoeplinger
reviewed
Jun 30, 2025
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
stephentoub
reviewed
Jun 30, 2025
| { | ||
| await writer.FlushAsync(); | ||
| await writer.CompleteAsync(); | ||
| GC.Collect(2, GCCollectionMode.Forced, true, true); |
There was a problem hiding this comment.
Why does this help?
Won't other tests running concurrently still experience low memory conditions?
And shouldn't the GC be automatically doing a collection if the memory pressure is so high? And even if it does a collection, that's not going to guarantee it gives the memory back to the OS, and it's the OS' OOM killer that's affecting this, right?
There was a problem hiding this comment.
I forced a compacting Gen 2 GC in the hope that it frees enough memory to have some non-ephemeral segments returned to the OS. But as you said, there's no guarantee. I'll investigate a bit more thoroughly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117090