[mono] Fix use of uninitialized variable #117140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlikely for this to fix an issue, but should prevent false positives with valgrind.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential uninitialized variable issue in the mono runtime by explicitly setting interface_offsets_full to zero when bitmap_only is true.
- Introduces a branch to initialize interface_offsets_full in the bitmap_only scenario.
- Prevents false positives with valgrind by ensuring consistent initialization in mono_class_setup_interface_offsets_internal.
|
cc @lambdageek |
vitek-karas
approved these changes
Jun 30, 2025
This was referenced Jun 30, 2025
lewing
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlikely for this to fix an issue, but should prevent false positives with valgrind. Use added in #73786