Instructions for adding MSBuild fast paths #49477
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the error message in the EvaluatorFastPathTests to provide clear guidance when the fast path check fails.
- Updated the assertion message with instructions and a link for bug filing
- Clarified guidance on handling failures by allowing an exclusion with a comment during the resolution process
baronfel
approved these changes
Jun 18, 2025
AR-May
approved these changes
Jun 19, 2025
Describe what to do when EnsureDotnetCommonProjectPropertyFunctionsOnFastPath fails.
baronfel
force-pushed
the
elaborate-fast-path-test
branch
from
d78086c to
de8800c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what to do when EnsureDotnetCommonProjectPropertyFunctionsOnFastPath fails.
Inspired by #49328.