related to issue 10466: add short cut ↑, ↓, ←, → to demo console #13513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13513 +/- ##
===================================================
+ Coverage 76.59791% 76.59837% +0.00046%
===================================================
Files 3230 3230
Lines 639165 639165
Branches 47297 47297
===================================================
+ Hits 489587 489590 +3
+ Misses 146007 145999 -8
- Partials 3571 3576 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Adds arrow key move shortcuts to the demo console’s design surface and cleans up the initialization loop.
- Extend the
DoActionmapping to includeKEYMOVE↑/↓/←/→commands - Hook arrow key Up/Down/Left/Right in
MainFormto invoke move actions - Refactor
InitFormDesignerto use a single loop and unified variable naming
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/test/integration/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.cs | Added KEYMOVEUP, KEYMOVEDOWN, KEYMOVELEFT, KEYMOVERIGHT to the DoAction switch |
| src/test/integration/DesignSurface/DemoConsole/MainForm.cs | Consolidated two loops into one, renamed isurf to designSurfaceExtended, and wired up KeyUp handlers for arrow keys |
Comments suppressed due to low confidence (1)
src/test/integration/DesignSurface/DesignSurfaceExt/DesignSurfaceExt.cs:353
- [nitpick] No automated tests verify the new arrow-key commands in
DoAction. Add unit or integration tests to ensureKEYMOVEUP,KEYMOVEDOWN,KEYMOVELEFT, andKEYMOVERIGHTare correctly handled.
"KEYMOVEUP" => MenuCommands.KeyMoveUp,
Comment on lines
42
to
45
| _selectionService = (ISelectionService)(designSurfaceExtended.GetIDesignerHost().GetService(typeof(ISelectionService))); | ||
| if (_selectionService is not null) | ||
| { | ||
| _selectionService.SelectionChanged += OnSelectionChanged; |
There was a problem hiding this comment.
Reassigning the single _selectionService field inside the loop will overwrite previous services and only keep the last one. Consider storing each surface’s ISelectionService separately or subscribing without relying on a single field.
Suggested change
| _selectionService = (ISelectionService)(designSurfaceExtended.GetIDesignerHost().GetService(typeof(ISelectionService))); | |
| if (_selectionService is not null) | |
| { | |
| _selectionService.SelectionChanged += OnSelectionChanged; | |
| var selectionService = (ISelectionService)(designSurfaceExtended.GetIDesignerHost().GetService(typeof(ISelectionService))); | |
| if (selectionService is not null) | |
| { | |
| _selectionServices[i] = selectionService; | |
| selectionService.SelectionChanged += OnSelectionChanged; |
Copilot uses AI. Check for mistakes.
LeafShi1
reviewed
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #10466
Proposed changes
After
Test methodology
manually
Microsoft Reviewers: Open in CodeFlow