fix #13508 Original text box is not empty after drag and drop the value to a new text box

[Epica3055]

Fixes #13508

code snippet before PR13431

            {
                ClearDropDescription();
                DragDropHelper.Drop(dragEvent);
            }

            _owner.OnDragDrop(dragEvent);
            *pdwEffect = (DROPEFFECT)dragEvent.Effect;
        }
        else
        {
            *pdwEffect = DROPEFFECT.DROPEFFECT_NONE;
        }

        _lastEffect = DragDropEffects.None;
        _lastDataObject = null;
        return HRESULT.S_OK;
    }

code snippet after PR13431

    private HRESULT HandleOnDragDrop(DragEventArgs e, IDataObjectAsyncCapability* asyncCapability, DROPEFFECT* pdwEffect)
    {
#pragma warning disable WFO5003 // Type is for evaluation purposes only
        if (asyncCapability is not null && _owner is IAsyncDropTarget asyncDropTarget)
#pragma warning restore WFO5003
        {
            // We have an implemented IAsyncDropTarget and the drag source supports async operations, push to a
            // worker thread to allow the drop to complete without blocking the UI thread.
            Task.Run(() =>
            {
                DROPEFFECT effect = DROPEFFECT.DROPEFFECT_NONE;

                try
                {
                    asyncDropTarget.OnAsyncDragDrop(e);
                    effect = (DROPEFFECT)e.Effect;
                }
                finally
                {
                    HRESULT result = asyncCapability->EndOperation(HRESULT.S_OK, null, (uint)effect);
                    asyncCapability->Release();
                }
            });

            // It isn't clear what we're supposed to do with the effect here as the actual result comes from
            // EndOperation. Perhaps DROPEFFECT_COPY would be a better default?
            *pdwEffect = DROPEFFECT.DROPEFFECT_NONE;
            return HRESULT.S_OK;
        }

        // We don't have the IAsyncDropTarget or the drag source doesn't support async operations, so just call
        // the normal OnDragDrop.

        DROPEFFECT effect = DROPEFFECT.DROPEFFECT_NONE;

        try
        {
            _owner.OnDragDrop(e);
            effect = (DROPEFFECT)e.Effect;
        }
        finally
        {
            if (asyncCapability is not null)
            {
                HRESULT result = asyncCapability->EndOperation(HRESULT.S_OK, null, (uint)effect);
                asyncCapability->Release();
            }
        }

        return HRESULT.S_OK;
    }

I think we forgot to update *pdwEffect after _owner.OnDragDrop(dragEvent);

Proposed changes

• update *pdwEffect after _owner.OnDragDrop(dragEvent);

Regression?

• Yes

Screenshots

Before

After

Test methodology

• manually

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40411%. Comparing base (9a17505) to head (5a9c261).
Report is 1 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                  @@
##                main      #13526          +/-   ##
====================================================
+ Coverage   76.59478%   97.40411%   +20.80933%     
====================================================
  Files           3230        1176        -2054     
  Lines         639165      352557      -286608     
  Branches       47297        5356       -41941     
====================================================
- Hits          489567      343405      -146162     
+ Misses        146015        8398      -137617     
+ Partials        3583         754        -2829     

Flag	Coverage Δ
Debug	97.40411% <ø> (+20.80933%)	⬆️
integration	?
production	?
test	97.40411% <ø> (ø)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[JeremyKuhne]

Thanks!