Handle ThreadContext cache more cleanly #13530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a concurrent backing collection. Note that we only ever create them if you ask for them on the current thread.
There was a problem hiding this comment.
Pull Request Overview
This PR improves thread-safety by switching from a Dictionary with manual locking to a ConcurrentDictionary in the ThreadContext cache.
- Replace manual locking with concurrent operations for thread context management.
- Remove unnecessary locks in DisposeInternal, ExitApplication, and Create methods as the backing collection is now thread-safe.
src/System.Windows.Forms/System/Windows/Forms/Application.ThreadContext.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Application.ThreadContext.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13530 +/- ##
===================================================
+ Coverage 76.59478% 76.59963% +0.00485%
===================================================
Files 3230 3230
Lines 639165 639148 -17
Branches 47297 47295 -2
===================================================
+ Hits 489567 489585 +18
+ Misses 146015 145987 -28
+ Partials 3583 3576 -7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Shyam-Gupta
reviewed
May 27, 2025
src/System.Windows.Forms/System/Windows/Forms/Application.ThreadContext.cs
Show resolved
Hide resolved
Shyam-Gupta
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to a concurrent backing collection. Note that we only ever create them if you ask for them on the current thread.
Microsoft Reviewers: Open in CodeFlow