-
Notifications
You must be signed in to change notification settings - Fork 1k
Add test for design binding picker #13536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b46fb99
to
8f4c5b8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13536 +/- ##
===================================================
+ Coverage 76.59683% 76.59848% +0.00164%
===================================================
Files 3230 3231 +1
Lines 639157 639185 +28
Branches 47295 47302 +7
===================================================
+ Hits 489574 489606 +32
+ Misses 146007 145995 -12
- Partials 3576 3584 +8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new unit test class to verify that the DesignBindingPicker
control and its subcomponents are initialized correctly.
- Adds
DesignBindingPickerTests
covering constructor setup, panel child controls, and a helper for control-type checks. - Introduces a private helper method
ContainsType<T>
to simplify asserting presence of child controls by type.
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding, in this or another PR, tests for the remaining public and protected methods: Pick
, OnVisibleChanged
, OnGotFocus
and RescaleConstantsForDpi
.
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Show resolved
Hide resolved
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/DesignBindingPickerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Related #10773
Microsoft Reviewers: Open in CodeFlow