Update ListView_Click_On_Second_Column_Does_Not_Alter_CheckBoxesAsync to add judgment and InvokeAsync #13626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to add judgment and InvokeAsync
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the UI is updated before calculating and moving the mouse to the second column of the first item in a ListView, and adds a guard to fail early if that subitem doesn’t exist.
- Calls
form.InvokeAsync(() => listView.Update())to process pending UI updates. - Adds a runtime check for
Items.CountandSubItems.Countbefore computinglistViewCenter, throwing if the subitem is missing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13626 +/- ##
===================================================
- Coverage 76.60828% 76.60625% -0.00203%
===================================================
Files 3253 3253
Lines 640996 640996
Branches 47439 47439
===================================================
- Hits 491056 491043 -13
- Misses 146290 146294 +4
- Partials 3650 3659 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #13288
Proposed changes
InvokeAsyncbefore executinglistView.RectangleToScreen(listView.Items[0].SubItems[1].Bounds)Microsoft Reviewers: Open in CodeFlow