Skip to content

Feature request: Treat pattern as case insensitive in e test -g 'pattern' #724

Closed
@nikwen

Description

@nikwen

Operating System

macOS 15.5 (24F74)

Expected Behavior

I'd expect e test -g "squirrel" to match the following tests:

autoUpdater behavior with update server with ElectronSquirrelPreventDowngrades enabled should not update to lower version numbers
autoUpdater behavior with update server with ElectronSquirrelPreventDowngrades enabled should not update to version strings that are not simple Major.Minor.Patch
autoUpdater behavior with update server with ElectronSquirrelPreventDowngrades enabled should still update to higher version numbers
autoUpdater behavior with update server with ElectronSquirrelPreventDowngrades enabled should compare version numbers correctly
autoUpdater behavior with update server with SquirrelMacEnableDirectContentsWrite enabled should hit the download endpoint when an update is available and update successfully when the zip is provided leaving the parent directory untouched

I'd expect the pattern to be treated as case insensitive.

Actual Behavior

The pattern is treated as case sensitive and doesn't match those tests:

$ e test --no-remote -g "squirrel" 
Running "/usr/local/bin/node ./script/spec-runner.js -g squirrel" in /Volumes/Electron/electron/src/electron
Triggering runners: main

Running: Main process specs
# tests 0
# pass 0
# fail 0
1..0
✓ Electron main process tests passed.

To Reproduce

e test -g "squirrel"

Screenshots

Additional Information

Why it matters: Maintainers might miss executing important tests. Especially with Squirrel tests which don't run in CI and are super critical to all Electron apps using the autoUpdater.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions