Skip to content

feat: add siso configuration support #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 19, 2025
Merged

feat: add siso configuration support #729

merged 4 commits into from
Jun 19, 2025

Conversation

MarshallOfSound
Copy link
Member

This PR does a few things:

  • Sets up basic SISO env vars and flags for the build command (and other depot tools commands)
  • Migrates a bunch of reclient* config options to rbe* or just remoteBuild to make it clear these are tool agnostic and work for anything consuming RBE in the electron build system

Default is still reclient, and siso doesn't work yet (so please don't try it)

@MarshallOfSound MarshallOfSound requested review from ckerr and a team as code owners June 19, 2025 18:47
@MarshallOfSound MarshallOfSound merged commit d92a145 into main Jun 19, 2025
8 checks passed
@MarshallOfSound MarshallOfSound deleted the sam/siso branch June 19, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants