test: add tests for JSON5 parsing in JSONLanguage
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumirlumir
commented
Jun 20, 2025
lumirlumir
commented
Jun 20, 2025
| @@ -1,5 +1,5 @@ | |||
| /** | |||
| * @filedescription Functions to fix up rules to provide missing methods on the `context` object. | |||
| * @fileoverview The JSONLanguage class. | |||
There was a problem hiding this comment.
Suggested change
| * @fileoverview The JSONLanguage class. | |
| * @fileoverview The JSONLanguage class. |
I think the previous description was somewhat incorrect. FYI, CSS Language uses a similar description as well.
https://github.com/eslint/css/blob/main/src/languages/css-language.js#L2
|
@mdjermanovic Thanks for your suggestion. I've added a new commit 272ebb4 |
mdjermanovic
deleted the
test-enhance-tests-for-json5-parsing-in-json-language
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Hello,
In this PR, I've added tests for JSON5 parsing in
JSONLanguage.I noticed that test cases for JSON5 parsing were missing, so I added them.
Additionally, I fixed some typos and removed unnecessary empty spaces for style formatting.
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?