Guard adding intel compiler flag behind check for intel compiler. #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons I don't yet fully understand, failing to guard the check for flag -wd654 will cause it to be added to certain clang configurations, and then cause compilation to fail. While exactly why this happens needs investigation, the fix proposed in this patch seems direct and simple enough to apply regardless.
LebedevRI
reviewed
Jun 18, 2025
| # (because of deprecated overload) | ||
| add_cxx_compiler_flag(-wd654) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
While there, can you move this line into the previous such guard block ^ ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't yet fully understand, failing to guard the check for flag -wd654 will cause it to be added to certain clang configurations, and then cause compilation to fail.
While exactly why this happens needs investigation, the fix proposed in this patch seems direct and simple enough to apply regardless.