Open
Description
Just one test took ~25 minutes due to shrinking. https://github.com/haskell/text/actions/runs/9201285542/job/25309228763?pr=590#step:6:1224
Should noShrinking
be added?
Metadata
Metadata
Assignees
Labels
No labels
Just one test took ~25 minutes due to shrinking. https://github.com/haskell/text/actions/runs/9201285542/job/25309228763?pr=590#step:6:1224
Should noShrinking
be added?
Activity
Bodigrim commentedon May 23, 2024
I imagine at the very least we don't want to shrink first three arguments of
BebeSparkelSparkel commentedon May 25, 2024
The encoding is not shrunk. I have wrapped the other two with
NoShrink
but without much improvement. See #597Bodigrim commentedon May 25, 2024
2007 shrinks is a high number, but on the other hand why did they take 1448 seconds? That's 0.7 seconds per test, which sounds a lot, given that the test data does not seem to be that huge.
BebeSparkelSparkel commentedon May 25, 2024
I think many more tests are run than 2007. If you look at numShrinkTries, so I think 2007 represents
numShrinks
but the number of tries is not shown.BebeSparkelSparkel commentedon May 25, 2024
I imagine there are so many shrinks tried because there are many variables to shrink
I think if the character variable is removed this would perform much better. Either, do not modify the characters or set them all to 'a'.
Bodigrim commentedon May 25, 2024
Dunno, maybe lumping
NoShrink
is the simplest solution. I'm not too keen to have a custom wrapper withinstance Arbitrary
here...BebeSparkelSparkel commentedon May 26, 2024
I just added
NoShrink
to quickcheck and it has been pulled nick8325/quickcheck#408. We could up the version of quickcheck and use it.