[2.x] Allow deepMerge on custom properties #732
+69
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify custom dot notated keys to use when deep merging data with Inertia.
For example, let's say you have a component that renders a user pagination via infinite loading using the
WhenVisible
component:This works great while scrolling through the site as new users get appended, however when you perform any additional request that results in a redirect to the
/users
route, the currentdeepMerge
strategy will append the users to the state.This PR aims to fix this by allowing you to specify on which key(s) the data should be merged. In the case of a pagination, you would return:
This tells Inertia to try and merge the
results.data
array by looking at theid
property of the underlying objects (if it exists).If the property is the same, the target object will be replaced with the new one from the response - otherwise it will be appended.
The JS implementation can be found here: inertiajs/inertia#2344