-
Notifications
You must be signed in to change notification settings - Fork 503
Update to Vite 6 #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Vite 6 #2315
Conversation
SuperDJ
commented
Apr 17, 2025
- Update to Vite v6;
- Update other packages to fix several vulnerabilities;
# Conflicts: # package-lock.json # packages/svelte/package.json # playgrounds/react/package.json # playgrounds/svelte4/package.json # playgrounds/svelte5/package.json # playgrounds/vue3/package.json
# Conflicts: # package-lock.json # packages/svelte/package.json # packages/svelte/test-app/Pages/Visits/Data/Object.svelte # playgrounds/react/package.json # playgrounds/svelte4/package.json # playgrounds/svelte5/package.json # playgrounds/vue3/package.json
I'm currently working on this, but it's not as easy as the Svelte test app in v4, and v5 requires quite some migration work. Maybe we even need separate test apps to keep supporting v4 and v5. Also, I think Vite is not a requirement to build the |
I've reverted the changes to the Svelte package so that we can keep building against Svelte 4 + Vite 5. Nonetheless, the Svelte test keeps failing in CI. I'm not sure why, as there are no changes now for Svelte. |
OK, it's unrelated. Running |
@pascalbaljet can that be related to the used node version? |
That's what I thought as well, but even running |
It's a recent update of Playwright. I'll open another PR to fix that first. |
Thanks for the PR and your patience, @SuperDJ! We'll migrate the Svelte adapter later on as we don't want to drop Svelte 4 support yet. |