Skip to content

Update to Vite 6 #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 18, 2025
Merged

Update to Vite 6 #2315

merged 16 commits into from
Jun 18, 2025

Conversation

SuperDJ
Copy link
Contributor

@SuperDJ SuperDJ commented Apr 17, 2025

  • Update to Vite v6;
  • Update other packages to fix several vulnerabilities;

SuperDJ added 4 commits April 24, 2025 13:32
# Conflicts:
#	package-lock.json
#	packages/svelte/package.json
#	playgrounds/react/package.json
#	playgrounds/svelte4/package.json
#	playgrounds/svelte5/package.json
#	playgrounds/vue3/package.json
# Conflicts:
#	package-lock.json
#	packages/svelte/package.json
#	packages/svelte/test-app/Pages/Visits/Data/Object.svelte
#	playgrounds/react/package.json
#	playgrounds/svelte4/package.json
#	playgrounds/svelte5/package.json
#	playgrounds/vue3/package.json
@SuperDJ SuperDJ requested a review from joetannenbaum May 23, 2025 10:55
@pascalbaljet
Copy link
Member

I'm currently working on this, but it's not as easy as the Svelte test app in v4, and v5 requires quite some migration work. Maybe we even need separate test apps to keep supporting v4 and v5.

Also, I think Vite is not a requirement to build the @inertiajs/svelte package, as @sveltejs/package is used for that. Not sure why that is a dev dependency as it builds perfectly fine without it.

@pascalbaljet
Copy link
Member

I've reverted the changes to the Svelte package so that we can keep building against Svelte 4 + Vite 5. Nonetheless, the Svelte test keeps failing in CI. I'm not sure why, as there are no changes now for Svelte.

@pascalbaljet
Copy link
Member

OK, it's unrelated. Running npm upgrade without the Vite 6 upgrade already breaks Svelte, so I'm fixing that first, and then I'll come back to this PR.

@SuperDJ
Copy link
Contributor Author

SuperDJ commented Jun 18, 2025

@pascalbaljet can that be related to the used node version?

@pascalbaljet
Copy link
Member

@pascalbaljet can that be related to the used node version?

That's what I thought as well, but even running npm upgrade on the master branch (with no other changes) fails.

@pascalbaljet
Copy link
Member

It's a recent update of Playwright. I'll open another PR to fix that first.

@pascalbaljet
Copy link
Member

Thanks for the PR and your patience, @SuperDJ! We'll migrate the Svelte adapter later on as we don't want to drop Svelte 4 support yet.

@pascalbaljet pascalbaljet merged commit 37ad20b into inertiajs:master Jun 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants