Skip to content

Fixes lingering issues to support workspaces in CLI #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rexios80
Copy link
Contributor

Copy link

vercel bot commented Jun 23, 2025

@Rexios80 is attempting to deploy a commit to the Invertase Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

docs-page bot commented Jun 23, 2025

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/dart_custom_lint~336

Documentation is deployed and generated using docs.page.

@Rexios80 Rexios80 changed the title Fixes CLI issues to support workspaces Fixes lingering issues to support workspaces in CLI Jun 23, 2025
@rrousselGit
Copy link
Collaborator

Hello there! We'll need tests, as per usual :)

@Rexios80
Copy link
Contributor Author

I am trying to write a test, but having a hard time getting it to work. This PR is more of a refactor than added functionality. The only code that might be questionable is adding followLinks: false since I thought there was already handling somewhere for that, but I was getting crashes in the ios symlinks folders.

@rrousselGit
Copy link
Collaborator

Well if it's fixing something, we need a regression test for it.

@Rexios80
Copy link
Contributor Author

Do you have any suggestions for where the test should go and other tests I should base it on?

@rrousselGit
Copy link
Collaborator

Depends on how you want to implement the test.

I'm not fully understanding the issue that is being fixed here, so I don't know. But you can always write a e2e test and place it next to the other ones (the ones that start a process)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants