-
Notifications
You must be signed in to change notification settings - Fork 391
Refactor jwt handling #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamuelWei
wants to merge
37
commits into
jumbojett:master
Choose a base branch
from
SamuelWei:refactor-jwt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DeepDiver1975 This PR implements the changes discussed in #484 and a few other items, as listed above. What are your thoughts? I also added a few new tests Are you fine with creating the tokens/jwts during the tests, or should they all be pre-created and stored in fixtures ? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of common tasks a pull request require complete
Closes #484
Added
getJtiFromBackChannel()
, Closes Fix: Verfify jti claim exists on backchannel logout token #481getJWSClaims
verifyJWSHeader
Changed
fetchURL
to return new custom Response class to improve testingNonce
claim must be present, Partially reverts Check nonce isset #280 (1)verifySignatures()
method signuture, accepting JWS object instead of stringRemoved
getResponseCode()
, replaced with new response methodgetStatus()
getResponseContentType()
, replaced with new response methodgetContentType()
verifyJWTClaims()
, replaced with individual checks using the ClaimCheckerManager, as the claims that have to be checked are too different across the different types of requests to move logic to a simple functionvalidateIssuer()
, replaced withIssuerChecker
verifyJWTSignature()
, replaced withverifyJWSSignature()
Fixed
Comments
1: Nonce must be present, see https://openid.net/specs/openid-connect-core-1_0.html#IDTokenValidation and https://openid.net/specs/openid-connect-core-1_0.html#ImplicitIDTValidation as we always send a nonce to the OpenID Connect server (see https://github.com/jumbojett/OpenID-Connect-PHP/blob/master/src/OpenIDConnectClient.php#L761)