Skip to content

Fixed jump to definition for notebooks that have special characters in filename and position for external jumps #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixed jump to definition for notebooks that have special characters in filename and position for external jumps #1128

wants to merge 7 commits into from

Conversation

darpan097
Copy link

@darpan097 darpan097 commented Jun 12, 2025 •
edited
Loading

References

fixes #1124, #1130

Works for me locally, though I had to change some things in the binder files and setup.cfg to make the local setup work. I did not commit these changes.

Code changes

  • Handle URI decode for special characters
  • Set cursor position to 'scroll' to the correct position in addition to selecting the jump target for external jumps.

User-facing changes

None

Backwards-incompatible changes

Chores

  • linted
  • tested
  • documented
  • changelog entry

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch darpan097/jupyterlab-lsp/feature/fix-code-jump

@darpan097 darpan097 marked this pull request as draft June 12, 2025 13:18
@darpan097 darpan097 marked this pull request as ready for review June 12, 2025 13:33
@darpan097 darpan097 mentioned this pull request Jun 12, 2025
Open
@darpan097 darpan097 marked this pull request as draft June 16, 2025 06:17
@darpan097 darpan097 changed the title Fixed jump to definition for notebooks that have special characters in filename Fixed jump to definition for notebooks that have special characters in filename and position for external jumps Jun 16, 2025
@darpan097 darpan097 marked this pull request as ready for review June 16, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jump to definition within the same notebook doesn't work if notebook name has a comma in it
1 participant
@darpan097