Initial MCP server config schema and loader #1377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlqqq
reviewed
Jun 18, 2025
Comment on lines
410
to
416
|
|
||
| def _link_jupyter_server_extension(self, server_app): | ||
| """Setup custom config needed by this extension.""" | ||
| c = Config() | ||
| c.ContentsManager.allow_hidden = True | ||
| server_app.update_config(c) | ||
| super()._link_jupyter_server_extension(server_app) |
There was a problem hiding this comment.
Just curious, what is the motivation for setting this globally? Is it so that users can see .jupyter from the JupyterLab UI?
There was a problem hiding this comment.
Yeah, otherwise there is no way for users to view and edit files in .jupyter.
JGuinegagne
reviewed
Jun 19, 2025
| except json.JSONDecodeError as e: | ||
| raise json.JSONDecodeError( | ||
| f"Invalid JSON in config file {config_path}: {e.msg}", e.doc, e.pos | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR build on top of #1376 by adding support for loading MCP server configuration from a JSON file in the
.jupyterdirectory. This PR has two components:This doesn't yet wire everything up and isn't fully ready for full review. Would love initial comments and feedback though.