[13.x] fix bug: enhance handling of empty values in grouping #55875
+31
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug within
groupBy
in collections. I understand it can be considered as a breaking change in 12.x, so maybe worth to consider to fix this issue in 13.xHow to reproduce
Prepare an array with some values, for demoing reasons, it's easier to spot the bug with
preserveKeys: true
enabled.The output after grouping missing key
20
, because of roles is an empty array, while key30
is an array with a single value ofnull
.Solution
Inside
groupBy
function, treat any empty array returned as a grouping key tonull
before processing. This ensures that items with an empty array are grouped under the “null” bucket rather than being skipped.