[12.x] Improve PHPDoc for the Illuminate\Cache folder files #56028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordanchoEftimov
changed the title
shaedrich
reviewed
Jun 13, 2025
| @@ -44,6 +44,7 @@ class DatabaseLock extends Lock | |||
| * @param int $seconds | |||
| * @param string|null $owner | |||
| * @param array $lottery | |||
| * @param int $defaultTimeoutInSeconds | |||
There was a problem hiding this comment.
Ich gehe mal davon aus, dass die Zahl nicht negativ sein kann:
Suggested change
| * @param int $defaultTimeoutInSeconds | |
| * @param non-negative-int $defaultTimeoutInSeconds |
There was a problem hiding this comment.
I assume that the time can not be negative.
This is better than Duolingo.
There was a problem hiding this comment.
Damn, sorry. Wasn't thinking apparently 😅 🤦🏻♂️
| @@ -169,6 +170,7 @@ public function put($key, $value, $seconds) | |||
| /** | |||
| * Store multiple items in the cache for a given number of seconds. | |||
| * | |||
| * @param array $values | |||
| * @param int $seconds | |||
There was a problem hiding this comment.
This probably as well:
Suggested change
| * @param int $seconds | |
| * @param non-negative-int $seconds |
| @@ -108,6 +108,7 @@ public function put($key, $value, $seconds) | |||
| /** | |||
| * Store multiple items in the cache for a given number of seconds. | |||
| * | |||
| * @param array $values | |||
There was a problem hiding this comment.
Since prefix() expects a string, so this can be reflected here:
Suggested change
| * @param array $values | |
| * @param array<string, mixed> $values |
|
This PR has conflicts. |
Conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved PHPDoc comments in the Illuminate\Cache folder to enhance code readability and IDE support. No functional changes.