Skip to content

[12.x] use offset() in place of skip() #56081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

browner12
Copy link
Contributor

in all of these changes, skip() is a direct alias of the offset() method, and performs no additional logic. switching to directly calling the offset() method means less code execution (minimally better performance) and reduces the call stack (nice for debugging).

follow up to #56080

in all of these changes, `skip()` is a direct alias of the `offset()` method, and performs no additional logic. switching to directly calling the `offset()` method means less code execution (minimallly better performance) and reduces the call stack (nice for debugging).
@taylorotwell taylorotwell merged commit 628d1bb into laravel:12.x Jun 19, 2025
62 checks passed
@browner12 browner12 deleted the AB-skip-offset-optimization branch June 19, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants