[12.x] use offset() and limit() in tests
#56089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we should not be testing the alias methods `skip()` and `take()` in our tests, but rather directly the actual methods performing the logic. if someone wanted to add a test for `skip()` and `take()` that'd be great, it'd be 1 method each ensuring they just pass along to their aliased counterparts.
|
failure appears unrelated as not from either of the tests I changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should not be testing the alias methods
skip()andtake()in our tests, but rather directly the actual methods performing the logic.if someone wanted to add a test for
skip()andtake()that'd be great, it'd be 1 method each ensuring they just pass along to their aliased counterparts.follow up to #56080 and #56081