Skip to content

add max-width to images on learnign-paths #6411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Touriist opened this issue Apr 28, 2025 · 3 comments · May be fixed by #6413
Open

add max-width to images on learnign-paths #6411

Touriist opened this issue Apr 28, 2025 · 3 comments · May be fixed by #6413
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/chore Necessary task

Comments

@Touriist
Copy link
Contributor

Current Behavior

The chapters in the learning paths have some humongous images, simply because they take up the full width of the container (width: 100%).

Image

Desired Situation

  • add a max-width

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Touriist Touriist added good first issue Good for newcomers help wanted Extra attention is needed kind/chore Necessary task labels Apr 28, 2025
@Jivi-this-side
Copy link

Greetings, @Touriist ! Based on the issue mentioned, I believe the necessary changes should be made here:

img{
height: 8.5rem;
width: 8.5rem;
}

Specifically, the following adjustments are required:

            max-width: 100%; { to Add max-width }
            object-fit: contain; { Ensures proper image scaling }

Please let me know if my understanding is accurate. I would be delighted to contribute and work on resolving this issue.

Thank you! 🌻

@vr-varad
Copy link
Contributor

vr-varad commented Apr 29, 2025

Sure! @Jivi-this-side LGTM

@vr-varad vr-varad assigned vr-varad and Jivi-this-side and unassigned vr-varad Apr 29, 2025
@Jivi-this-side Jivi-this-side linked a pull request Apr 29, 2025 that will close this issue
1 task
@Jivi-this-side
Copy link

Greeetings, @vr-varad ! I have submitted the pull request for your review. I kindly request your valuable time to assess the proposed changes.

Thank you for your attention and consideration. I sincerely appreciate the opportunity to contribute. Wishing you a wonderful day ahead!
Thank you ! 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/chore Necessary task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants