TEST: MacOS #80
Open
TEST: MacOS #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds macOS-specific functionality for handling MSSQL cursor fetch operations and introduces a new pipeline job to run Python tests on macOS.
- Modified fetchone() in mssql_python/cursor_mac.py to handle SQL_NO_DATA.
- Added a new 'PytestOnMacOS' job in eng/pipelines/pr-validation-pipeline.yml to enable testing on macOS.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mssql_python/cursor_mac.py | Added a branch in fetchone() to return None for SQL_NO_DATA conditions. |
| eng/pipelines/pr-validation-pipeline.yml | Introduced a new macOS pipeline job to install dependencies, start Dockerized SQL Server, build bindings, and run pytest. |
Comment on lines
105
to
107
| for i in {1..30}; do | ||
| docker exec sql2022 /opt/mssql-tools/bin/sqlcmd -U SA -P $(DB_PASSWORD) -Q "SELECT 1" && break | ||
| sleep 2 |
There was a problem hiding this comment.
The fixed 30-iteration loop for SQL Server startup may not be sufficient in slower environments. Consider making the wait time or iteration count configurable or implement a dynamic check for server readiness.
Suggested change
| for i in {1..30}; do | |
| docker exec sql2022 /opt/mssql-tools/bin/sqlcmd -U SA -P $(DB_PASSWORD) -Q "SELECT 1" && break | |
| sleep 2 | |
| MAX_WAIT_TIME=60 # Maximum wait time in seconds | |
| POLL_INTERVAL=2 # Polling interval in seconds | |
| ELAPSED_TIME=0 | |
| until docker exec sql2022 /opt/mssql-tools/bin/sqlcmd -U SA -P $(DB_PASSWORD) -Q "SELECT 1"; do | |
| if [ $ELAPSED_TIME -ge $MAX_WAIT_TIME ]; then | |
| echo "SQL Server did not become ready within $MAX_WAIT_TIME seconds." | |
| exit 1 | |
| fi | |
| sleep $POLL_INTERVAL | |
| ELAPSED_TIME=$((ELAPSED_TIME + POLL_INTERVAL)) |
Copilot uses AI. Check for mistakes.
… bewithgaurav/mac_pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT PR: Not for Review