FEAT: x86_64 (Intel) Support for MacOS #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
gargsaumya
requested changes
Jun 19, 2025
gargsaumya
previously approved these changes
Jun 19, 2025
### Summary This pull request adds a new job to the `pr-validation-pipeline.yml` file to enable running Python tests on macOS. The job includes steps for setting up the environment, installing dependencies, building bindings, running tests with coverage, and publishing results. Some Docker-related steps are commented out for now. ### Additions to the pipeline: * **New job for macOS testing**: Added a `PytestOnMacOS` job to the pipeline, which uses the `macos-latest` image to run Python tests. * **Python environment setup**: Configured the job to use Python 3.13.5 and installed dependencies from `requirements.txt`. * **Build and test execution**: - Built pybind bindings via `build.sh`. - Ran `pytest` with coverage and published the results. ### Commented-out Docker-related steps: * Steps for installing and configuring Docker on macOS, including setting up Colima and running an SQL Server container, are included but commented out for now. ### Issue Reference Fixes [AB#37749](https://sqlclientdrivers.visualstudio.com/c6d89619-62de-46a0-8b46-70b92a84d85e/_workitems/edit/37749) ### Checklist - [x] **Tests Passed** (if applicable) - [x] **Code is formatted** - [x] **Docs Updated** (if necessary) ### Testing Performed <!-- How was this fix tested? --> - [x] Unit Tests
sumitmsft
previously approved these changes
Jun 19, 2025
gargsaumya
previously approved these changes
Jun 19, 2025
bewithgaurav
dismissed stale reviews from gargsaumya and sumitmsft
The base branch was changed.
|
Changed the base branch to main now that previous branch is shipped, will target main now. |
sumitmsft
approved these changes
Jun 19, 2025
gargsaumya
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces license files for the Microsoft ODBC Driver 18 for SQL Server and updates the
README.mdformssql_python/pybindto clarify supported architectures and improve build instructions.License File Additions:
mssql_python/libs/macos/arm64/share/doc/msodbcsql18/LICENSE.txtandmssql_python/libs/macos/x86_64/share/doc/msodbcsql18/LICENSE.txt. These files outline usage rights, distribution requirements, and legal disclaimers.Documentation Updates:
README.mdinmssql_python/pybindto specify supported architectures for Windows and MacOS:arm64and allow detection of system architecture during the build process.Issue Reference
Fixes AB#34976
Checklist
Testing Performed