Skip to content

Php support #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Php support #107

wants to merge 6 commits into from

Conversation

v4rgas
Copy link
Contributor

@v4rgas v4rgas commented May 1, 2025

Closes #106

I tried using phpactor since it is open source but it was not working properly, every time I ran it It found more and more repeated references for no reason at all.

Inteliphense worked out of the box, the only bad thing is that you need to install the dependency with npm and that is it closed source, maybe we should add a warning when running multilspy with intelephense?

anyways, ill add a few more test but for now ill open the pr anyways

pd: I also fixed the readme since it was missing some languages

@v4rgas
Copy link
Contributor Author

v4rgas commented May 1, 2025

its only finding the references within the same file, would u mind helping me debug that? i cannot understand why isnt indexing the entire project

i tried modifying the initialization params but i had no luck, am i missing something?

@v4rgas v4rgas marked this pull request as draft May 12, 2025 16:02
@MischaPanch
Copy link

We added php support via intelephense to our multilspy copy, could be useful for you as reference. Since there's quite some deviation from the original in our version at the moment, the code would need to be a bit adapted for merging back to multilspy. But it's a straightforward task.

The functionality of the new LS is tested in CI on windows, ubuntu and macos - everything seems to work fine.
oraios/serena#119

@MischaPanch
Copy link

its only finding the references within the same file, would u mind helping me debug that? i cannot understand why isnt indexing the entire project

I also had to face an fix this issue. I think it's a bug in the LS, we "fixed" it by just waiting a bit before requesting references and definitions. You'll see it in the PR I mentioned above

@v4rgas
Copy link
Contributor Author

v4rgas commented May 20, 2025

thanks for letting me know, ill check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PHP support
2 participants