-
Notifications
You must be signed in to change notification settings - Fork 276
Add TestCategories property to ITestDataRow for per-test-case categorization #5795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
…ng categories Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
…feature Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
TestCategories
to ITestDataRow
/// Gets or sets the test categories for the test case. | ||
/// </summary> | ||
[DataMember] | ||
public IList<string>? TestCategories { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/TestFramework/TestFramework/TestDataRow.cs(47,44): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'Microsoft.VisualStudio.TestTools.UnitTesting.TestDataRow.TestCategories.get -> System.Collections.Generic.IList<string!>?' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the RS0016 analyzer error by adding the TestCategories property getter and setter to PublicAPI.Unshipped.txt. The new property is now properly declared as part of the public API surface. (64510f6)
…analyzer error Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot There is a merge conflict. Can you fix it? |
src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR adds support for applying test categories to individual test data rows in parameterized tests, addressing a long-standing user request for more granular test categorization.
Changes
Core API Changes
TestCategories
property toITestDataRow
interfaceTestCategories
property inTestDataRow<T>
class with[DataMember]
attributeDiscovery Logic Updates
TestDataSourceHelpers.TryHandleITestDataRow()
to extract test categories from test data rowsAssemblyEnumerator
to merge test categories from test data rows with existing method/class/assembly level categoriesUsage Example
Benefits
Test Coverage
TestDataRow
andTestDataSourceHelpers
This enables scenarios like:
Fixes #4089.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
5rqvsblobprodcus385.vsblob.vsassets.io
/home/REDACTED/work/testfx/testfx/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:quiet /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/testfx/testfx/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/testfx/testfx/artifacts/toolset/10.0.0-beta.25316.2.txt
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.