Skip to content

Allow completion providers for undefined shell types #253011

@Tyriar

Description

@Tyriar

This if statement is the reason we don't yet allow Pseudoterminal-based terminals from using custom completion providers:

Image

// Require a shell type for completions. This will wait a short period after launching to
// wait for the shell type to initialize. This prevents user requests sometimes getting lost
// if requested shortly after the terminal is created.
await this._shellTypeInit;
if (!this.shellType) {
return;
}

We should keep the await for shell type initialization, but allow proceeding when shellType is undefined.

I also see shellType must be defined to report telemetry, we should report it regardless when there are completions.

Metadata

Metadata

Labels

bugIssue identified by VS Code Team member as probable bugterminal-suggest

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions