Don't render text when the view is hidden

[pisv]

Currently, there is a check in view.ts that avoids rendering text when the view node is not connected. This PR proposes to add another simple check that would avoid rendering text when the view node is hidden.

It would be useful for Monaco adopters such as Eclipse Theia, which have an editor lifecycle that differs from the editor lifecycle in the VS Code workbench. As such, it should make Monaco more reusable outside VS Code.

Please see eclipse-theia/theia#15500 (comment) for some background.

Thank you!

[hediet]

Thanks for the PR! What happens if the expression !this.domNode.domNode.offsetParent will evaluate to true at some later moment in time? Will the text be rerendered?

[pisv]

Thanks for the PR! What happens if the expression !this.domNode.domNode.offsetParent will evaluate to true at some later moment in time? Will the text be rerendered?

Thanks for looking! I guess the answer is probably 'no', but is not it similar to !this.domNode.domNode.isConnected? (I've quickly searched for references to isConnected and couldn't find any relevant hints for this case... Am I missing something?)

[hediet]

I've quickly searched for references to isConnected and couldn't find any relevant hints for this case...

Maybe its a bug there already, I don't even know what isConnected means.
Would be good to have a full understanding of how the editor behaves when the editor transitions between visible and not visible.
This check seems like a hot fix for a specific scenarios, but I'm sure it can cause other problems.

[pisv]

You are probably right. Let's close it then. Thank you.