add -n to parameter expansion zsh

[anthonykim1]

Resolves: #248463 (comment)

[anthonykim1]

Could @Tyriar @meganrogge give this a try?
Seems to work on my end.

Relevant setting: terminal.integrated.shellIntegration.environmentReporting

Also do we not show the path to shell integration script on terminal tab hover anymore?

[meganrogge]

Hi Anthony, thanks for working on this. Can you pls explain what your changes do?

[anthonykim1]

Yeap! @meganrogge
So we added the parameter expansion approach to avoid using -v since it was invalid command for people's zsh.
But even [[ ${(P)var+_} ]]; did not seem enough for person using zsh 5.0.2.

Adding -n makes it more robust and more compatible. Essentially with -n "${(P)key:-}" we check if the value is non-empty.
We are checking if both key, and non-empty value are present when parsing through env variables we want to send as shell env api.

stale