Fix hex color decorators for 3-digit and 4-digit hex colors #252338
+51
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hex colors were not showing color preview decorators for 3-digit (
#RGB
) and 4-digit (#RGBA
) hex formats, even when properly quoted in strings. The regex pattern indefaultDocumentColorsComputer.ts
only supported 6-digit (#RRGGBB
) and 8-digit (#RRGGBBAA
) hex colors.Before
After
Changes Made
Updated regex pattern in
defaultDocumentColorsComputer.ts
to include:#RGB
(expands to#RRGGBB
)#RGBA
(expands to#RRGGBBAA
)Added comprehensive test cases covering all hex color formats
Maintained security measures - preserved existing whitespace/quote prefix requirements to prevent GitHub issue numbers from being detected as colors
Security Considerations
The fix maintains the existing security behavior:
background: '#abc'
- Shows decorator (quoted)color: #abc
- Shows decorator (space prefix)issue#abc123
- No decorator (no space/quote prefix)The Color.Format.CSS.parseHex function already supports 3-digit and 4-digit hex parsing, so no changes were needed to the color parsing logic.
Fixes #239446.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.