Skip to content

Show more embeddings settings #252446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Show more embeddings settings #252446

merged 1 commit into from
Jun 25, 2025

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jun 25, 2025

This PR adds more embeddings settings considering the number of settings is currently a hard-coded constant in core.

I'd like to move the constant to the Copilot side during debt week.

@rzhao271 rzhao271 requested a review from sbatten June 25, 2025 20:01
@rzhao271 rzhao271 self-assigned this Jun 25, 2025
@rzhao271 rzhao271 added this to the June 2025 milestone Jun 25, 2025
@rzhao271 rzhao271 enabled auto-merge (squash) June 25, 2025 20:01
@rzhao271 rzhao271 merged commit dfac64c into main Jun 25, 2025
8 checks passed
@rzhao271 rzhao271 deleted the rzhao271/more-embeddings branch June 25, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants