Fix terminal tab order when re-running all tasks #252448
Draft
+27
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "Rerun All Running Tasks" command, terminal tabs were getting mixed up because tasks were being restarted in arbitrary dictionary order rather than their original terminal tab order.
Problem
The issue occurred because:
getActiveTasks()
returned tasks in dictionary iteration order (arbitrary)Promise.allSettled()
created race conditionsThis resulted in terminals being recreated in a different order than they originally appeared in the tabs.
Solution
Modified
getActiveTasks()
inTerminalTaskSystem
:_terminalGroupService.instances
getActiveTasks()
with consistent orderingModified
_runRerunAllRunningTasksCommand()
inAbstractTaskService
:Testing
Manual verification confirms that tasks are now correctly ordered by terminal position (Task A, Task B, Task C) instead of dictionary order (Task C, Task A, Task B). Edge cases are handled properly (missing terminals placed at end).
Impact
This fix resolves the specific terminal tab ordering issue while improving overall task ordering consistency throughout the application. All existing
getActiveTasks()
usages now benefit from predictable, user-friendly ordering.Fixes #252447.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.