Authentication polish around account access #252452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adopts the AuthenticationQueryService in: 1. Manage Trusted Extensions quick pick 2. An MCP server's Quick Pick (shows Sign Out or Disconnect account) 3. An MCP server's view (shows Sign Out or Disconnect account) 4. Depend on this service instead of some sily map in the MCP Registry 5. Have the `AuthenticationAccessService` own looking at the product.json so that implementers don't need to know about it This also contains a number of squashed bugs... 1. We were not cleaning up storage state when an extension or mcp server was uninstalled 2. The Extension Access service wasn't using `ExtensionIdentifier.toKey`
DonJayamanne
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts the AuthenticationQueryService in:
AuthenticationAccessServiceown looking at the product.json so that implementers don't need to know about itThis also contains a number of squashed bugs...
ExtensionIdentifier.toKey