Skip to content

Fix: Add restart button to Running Extensions view (#250201) #252462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ranvirdeshmukh
Copy link

Fixes #250201

Summary

This PR adds the restart button functionality to the Running Extensions view, ensuring consistency with the main Extensions view behavior when disabling extensions.

Problem

When extensions are disabled from the Running Extensions view (View → Extensions → Show Running Extensions), no restart button appears to notify users that extensions need to be restarted. This is inconsistent with the main Extensions view which properly shows a "Restart Extensions" button.

Solution

  • Import ExtensionRuntimeStateAction in abstractRuntimeExtensionsEditor.ts
  • Add restart action to the actionbar in the renderElement method
  • Ensure the action is only added when element.marketplaceInfo exists and the action is enabled
  • Properly dispose of the action with elementDisposables to prevent memory leaks

Changes Made

  • File: src/vs/workbench/contrib/extensions/browser/abstractRuntimeExtensionsEditor.ts
    • Added import for ExtensionRuntimeStateAction
    • Modified renderElement method to include restart action in actionbar
    • Added proper disposal management

Testing Steps

  1. Open VSCode
  2. Install and enable some extensions
  3. Go to View → Extensions → Show Running Extensions
  4. Right-click on a running extension and select Disable
  5. Verify: A restart button now appears (previously this was missing)
  6. Verify: Clicking the restart button properly restarts extensions
  7. Verify: Behavior matches the main Extensions view

Checklist

- Import ExtensionRuntimeStateAction in abstractRuntimeExtensionsEditor.ts
- Add restart action to actionbar in renderElement method
- Ensures restart button appears when disabling extensions from Running Extensions view
- Fixes issue microsoft#250201
- Import ExtensionRuntimeStateAction in abstractRuntimeExtensionsEditor.ts
- Add restart action to actionbar in renderElement method
- Ensures restart button appears when disabling extensions from Running Extensions view
- Maintains consistency with main Extensions view behavior
- Fixes microsoft#250201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restart Extensions button not created when disabling extensions from Running Extensions view
2 participants