Skip to content

PromptParser: set language as input #252616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

PromptParser: set language as input #252616

merged 1 commit into from
Jun 27, 2025

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Jun 27, 2025

The parser would not parse a header if the language was not set on the underlying text model. But on window reload it takes a while until the textModel gets the correct language id, as the language contributions come from extension that need to be loaded first.
As we know what we parse, we pass in the language when starting the parser

Fixes https://github.com/microsoft/vscode-copilot/issues/17988
Fixes #249294

@aeschli aeschli self-assigned this Jun 27, 2025
@aeschli aeschli enabled auto-merge (squash) June 27, 2025 09:51
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 27, 2025
@aeschli aeschli merged commit 0dbee9e into main Jun 27, 2025
8 checks passed
@aeschli aeschli deleted the aeschli/educational-wallaby branch June 27, 2025 11:11
lszomoru pushed a commit that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The reference in instructions file does not take effect in the Remote SSH environment.
2 participants