Fix fetch tool to fallback to file service for non-http schemes #252683

Copilot · 2025-06-27T19:02:45Z

This prevents MCP resource URIs (like test://static/resource/50) from being incorrectly processed by the fetch tool. MCP resources should be handled by VS Code's filesystem providers instead. - Modified FetchWebPageTool._parseUris() to filter out non-HTTP(S) schemes - Added comprehensive tests for the new scheme filtering behavior - Non-HTTP(S) URIs will now be treated as invalid and skipped Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

TylerLeonhardt · 2025-06-27T19:43:53Z

I'd rather the tests implemented a TestWebContentExtractorService which can be constructed with a map of like "Uris to fake page contents" and then have tests that test the actual API not private methods

…ng private methods Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot · 2025-06-27T19:51:46Z

I'd rather the tests implemented a TestWebContentExtractorService which can be constructed with a map of like "Uris to fake page contents" and then have tests that test the actual API not private meth...

I've refactored the tests to use a TestWebContentExtractorService that implements IWebContentExtractorService with configurable URI-to-content mapping. The tests now validate the public API behavior (via the invoke method) instead of testing private methods directly. This approach provides better test isolation and follows testing best practices. Commit: a62dae1

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

electronjs.org
- Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

connor4312 · 2025-06-27T19:56:07Z

I think what would be nice here is actually to just serve the file data if it's something the IFileService can resolve. Sure it might not be 'correct' use of the fetch tool, but that would make usages of it not break :)

…P schemes Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

Copilot · 2025-06-27T20:09:51Z

I think what would be nice here is actually to just serve the file data if it's something the IFileService can resolve. Sure it might not be 'correct' use of the fetch tool, but that would make usages...

I've implemented your suggestion to serve file data via IFileService for non-HTTP/HTTPS schemes. The fetch tool now:

Processes HTTP/HTTPS URLs through the web content extractor (unchanged)
Processes other URLs through IFileService.readFile()
Only marks URLs as "Invalid" if both approaches fail

This makes MCP resources work seamlessly - instead of rejecting test://static/resource/50, it now attempts to read the content via the file service. The tool gracefully falls back to "Invalid URL" only if the file service can't handle the scheme either.

Commit: 2df3c81

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

electronjs.org
- Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

TylerLeonhardt · 2025-06-27T20:14:16Z

I like the strategy of:

if we get an HTTP or HTTPS url, use the web extractor
otherwise try the IFileService to resolve the url return content if it does
otherwise mark them as invalid

However, let's not change the description of the tool as I don't want this fall back to be used too heavily over other read tools.

And remember order matters in what you return back so maintain the same order in the response.

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot · 2025-06-27T20:19:49Z

I like the strategy of:

if we get an HTTP or HTTPS url, use the web extractor

otherwise try the IFileService to resolve the url return content if it does
...

I've reverted the tool description back to the original text that only mentions web pages, while keeping the file service fallback functionality intact. The tool maintains proper URL order in responses as requested. Commit: 9c36f75

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

electronjs.org
- Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

TylerLeonhardt · 2025-06-27T22:59:30Z

Can you use this FileService implementation as the implementation on the web? Right now that's using the Null one

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot · 2025-06-27T23:04:47Z

Can you use this FileService implementation as the implementation on the web? Right now that's using the Null one

I've implemented a FileService-based WebContentExtractorService for the web platform. The web workbench now uses FileServiceWebContentExtractorService instead of NullWebContentExtractorService, which allows HTTP/HTTPS URLs to be handled via the FileService infrastructure. Commit: 1d2d406

) * Initial plan * Fix fetch tool to only handle HTTP/HTTPS schemes This prevents MCP resource URIs (like test://static/resource/50) from being incorrectly processed by the fetch tool. MCP resources should be handled by VS Code's filesystem providers instead. - Modified FetchWebPageTool._parseUris() to filter out non-HTTP(S) schemes - Added comprehensive tests for the new scheme filtering behavior - Non-HTTP(S) URIs will now be treated as invalid and skipped Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> * Refactor tests to use TestWebContentExtractorService instead of testing private methods Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> * Enhance fetch tool to serve file content via IFileService for non-HTTP schemes Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com> * Revert tool description to original text as requested Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> * Implement FileService-based WebContentExtractorService for web platform Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> * Handle binary data * style * don't adopt this yet --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com> Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com> Co-authored-by: Tyler Leonhardt <tyleonha@microsoft.com>

Initial plan

435dc32

Copilot AI assigned Copilot and TylerLeonhardt Jun 27, 2025

Copilot started work on behalf of TylerLeonhardt June 27, 2025 19:02 View session

Copilot AI changed the title ~~[WIP] can't get content of MCP resource~~ Fix fetch tool to only handle HTTP/HTTPS schemes for MCP resources Jun 27, 2025

Copilot finished work on behalf of TylerLeonhardt June 27, 2025 19:13

Copilot AI requested a review from TylerLeonhardt June 27, 2025 19:13

Copilot started work on behalf of TylerLeonhardt June 27, 2025 19:43 View session

Refactor tests to use TestWebContentExtractorService instead of testi…

a62dae1

…ng private methods Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot finished work on behalf of TylerLeonhardt June 27, 2025 19:52

Copilot started work on behalf of connor4312 June 27, 2025 19:56 View session

Enhance fetch tool to serve file content via IFileService for non-HTT…

2df3c81

…P schemes Co-authored-by: connor4312 <2230985+connor4312@users.noreply.github.com>

Copilot AI requested a review from connor4312 June 27, 2025 20:10

Copilot finished work on behalf of connor4312 June 27, 2025 20:10

Copilot started work on behalf of TylerLeonhardt June 27, 2025 20:14 View session

Revert tool description to original text as requested

9c36f75

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot finished work on behalf of TylerLeonhardt June 27, 2025 20:20

Copilot started work on behalf of TylerLeonhardt June 27, 2025 22:59 View session

Implement FileService-based WebContentExtractorService for web platform

1d2d406

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

Copilot finished work on behalf of TylerLeonhardt June 27, 2025 23:05

Handle binary data

ccb8fd6

style

66e680d

TylerLeonhardt changed the title ~~Fix fetch tool to only handle HTTP/HTTPS schemes for MCP resources~~ Fix fetch tool to fallback to file service for non-http schemes Jun 29, 2025

TylerLeonhardt marked this pull request as ready for review June 29, 2025 05:38

vs-code-engineering bot added this to the June 2025 milestone Jun 29, 2025

don't adopt this yet

028b44c

TylerLeonhardt approved these changes Jun 29, 2025

View reviewed changes

TylerLeonhardt enabled auto-merge (squash) June 29, 2025 06:21

lszomoru approved these changes Jun 29, 2025

View reviewed changes

TylerLeonhardt merged commit f673cdd into main Jun 29, 2025
8 checks passed

TylerLeonhardt deleted the copilot/fix-250495 branch June 29, 2025 17:37

codeOwlAI mentioned this pull request Jun 30, 2025

Feature implementation from commits 9bf5ea5..6ccdb0f codeOwlAI/vscode#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix fetch tool to fallback to file service for non-http schemes #252683

Fix fetch tool to fallback to file service for non-http schemes #252683

Uh oh!

Copilot AI commented Jun 27, 2025 •

edited by TylerLeonhardt

Loading

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

connor4312 commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Fix fetch tool to fallback to file service for non-http schemes #252683

Fix fetch tool to fallback to file service for non-http schemes #252683

Uh oh!

Conversation

Copilot AI commented Jun 27, 2025 • edited by TylerLeonhardt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

connor4312 commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Copilot AI commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jun 27, 2025 •

edited by TylerLeonhardt

Loading

Copilot AI commented Jun 27, 2025 •

edited

Loading

Copilot AI commented Jun 27, 2025 •

edited

Loading

Copilot AI commented Jun 27, 2025 •

edited

Loading