Skip to content

Regenerate Client Id when invalid_client is returned #252714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

TylerLeonhardt
Copy link
Member

Fixes #250960

@TylerLeonhardt TylerLeonhardt self-assigned this Jun 27, 2025
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) June 27, 2025 22:38
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 27, 2025
this._logger.error(`Error polling for token: ${error}`);
// Continue polling on network errors
continue;
throw new Error(`Error polling for token: ${error}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you wanted to keep the logger here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah the error will be logged higher up

@TylerLeonhardt TylerLeonhardt merged commit 798f191 into main Jun 27, 2025
8 checks passed
@TylerLeonhardt TylerLeonhardt deleted the tyler/faithful-marmot branch June 27, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCP Authenthication - VsCode does not evict client when client can't be authorized
2 participants