Set specific model for prompts and modes #252893
Merged
+353
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
previously approved these changes
Jun 29, 2025
| @@ -509,6 +509,16 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge | |||
| } | |||
| } | |||
|
|
|||
| public switchModelByName(modelName: string): boolean { | |||
| const models = this.getModels(); | |||
| const model = models.find(m => m.metadata.name === modelName); | |||
There was a problem hiding this comment.
BYOK and built-in gpt-4.1 have the same name. You could use ID instead, or include a vendor field, or just do it this way.
There was a problem hiding this comment.
I see. I want the same label as in model picker. The id could be confusing.
For BYK I guess it's up to the user to choose a better name? Al
I can look into additional (optional) qualification if this becomes a real issue.
There was a problem hiding this comment.
For BYOK, the name comes from the model provider. So here for example I have two gpt-4.1, no way to tell which I'm paying real money for :)
What else should the name be if not 'GPT 4.1'? In every other scenario it's presented in some context where I know which provider it's from.
alexr00
previously approved these changes
Jun 30, 2025
alexr00
approved these changes
Jun 30, 2025
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-copilot/issues/18375