Skip to content

[WIP] dotnet test html logger throws execption when using special characters in DataRow attributes. #15090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 12, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

Cannot move there, see: dotnet/sdk#38983

Fixes #10431.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@nohwnd
Copy link
Member

nohwnd commented Jun 12, 2025

looks like your session timed out. Try again.

@nohwnd
Copy link
Member

nohwnd commented Jun 13, 2025

@copilot try one more time.

Copy link
Contributor Author

Copilot AI commented Jun 13, 2025

@copilot try one more time.

I've analyzed the issue and implemented a fix. The problem was that the HtmlTransformer was using tolerant settings for reading XML (CheckCharacters = false) but strict settings for writing, causing exceptions with special characters in DataRow attributes. I've updated the Transform method to use CheckCharacters = false for both reading and writing XML. The fix is now ready and includes comprehensive tests.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 80zvsblobprodcus35.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • 8xbvsblobprodcus382.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • bcnvsblobprodcus378.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • c50vsblobprodcus330.vsblob.vsassets.io
    • Triggering command: /home/REDACTED/work/vstest/vstest/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/vstest/vstest/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/vstest/vstest/artifacts/toolset/9.0.0-beta.25302.2.txt (dns block)
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • d0svsblobprodcus381.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • https://api.github.com/repos/dotnet/sdk/issues/38983
    • Triggering command: curl -s REDACTED (http block)
  • imzvsblobprodcus368.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • jd4vsblobprodcus366.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • jrqvsblobprodcus343.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • kh4vsblobprodcus325.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • kmuvsblobprodcus389.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • l49vsblobprodcus358.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • lylvsblobprodcus31.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • o3svsblobprodcus318.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)
  • x3yvsblobprodcus370.vsblob.vsassets.io
    • Triggering command: dotnet test test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests.csproj --filter TestResultHandlerShouldHandleSpecialCharactersInDataRowWithoutThrowingException --verbosity normal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Co-authored-by: nohwnd <5735905+nohwnd@users.noreply.github.com>
Copilot finished work on behalf of nohwnd June 13, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet test html logger throws execption when using special characters in DataRow attributes.
2 participants