Skip to content

docs(signals): add Events page #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 28, 2025
Merged

docs(signals): add Events page #4788

merged 9 commits into from
May 28, 2025

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4777

What is the new behavior?

Documentation for the Events plugin has been added.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented May 21, 2025

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 01d0085
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/68364fe65c13670008aa6c3f
😎 Deploy Preview https://deploy-preview-4788--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 21, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 01d0085
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/68364fe64893d500085bf24b
😎 Deploy Preview https://deploy-preview-4788--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Once all the PRs of the docs are merged, we'll have to update the new docs (in the wwwroot folder as well). I'll create an issue for this so we don't forget about it.

Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I left one remark about the introduction.

@markostanimirovic you can ignore those suggestions about adding the to the headers if you don't want them for stylistic issues.

markostanimirovic and others added 8 commits May 28, 2025 00:00
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
Co-authored-by: Rainer Hahnekamp <rainer.hahnekamp@gmail.com>
Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@markostanimirovic markostanimirovic merged commit c4ccd23 into main May 28, 2025
14 checks passed
@markostanimirovic markostanimirovic deleted the docs/signals/events branch May 28, 2025 09:06
rainerhahnekamp pushed a commit to rainerhahnekamp/ngrx that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/signals/events: Add Documentation Page
3 participants