-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix(signals): expose WritableStateSource to withFeature callback #4792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signals): expose WritableStateSource to withFeature callback #4792
Conversation
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
✅ Deploy Preview for ngrx-site-v19 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. I left two comments for tiny changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @GuillaumeNury! 👍
Thanks @GuillaumeNury! |
@rainerhahnekamp @markostanimirovic you're welcome! Thank you for the rebase and the fix. Sorry I was off for some days 🙈 |
All good @GuillaumeNury. We managed to do the last steps on our own 👍 |
Fix #4766
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
patchState
cannot be called withinwithFeature
.Closes #4766
What is the new behavior?
patchState
can be called withinwithFeature
.Does this PR introduce a breaking change?
Other information
I hesitated between
feat
andfix
. Do not hesitate to ask me to change anything