Skip to content

fix(signals): expose WritableStateSource to withFeature callback #4792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GuillaumeNury
Copy link
Contributor

Fix #4766

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

patchState cannot be called within withFeature.

Closes #4766

What is the new behavior?

patchState can be called within withFeature.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

I hesitated between feat and fix. Do not hesitate to ask me to change anything

Copy link

netlify bot commented May 22, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d41f46
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6838c61ff47bef000856f133

Copy link

netlify bot commented May 22, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 0d41f46
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6838c61ff47bef000856f138
😎 Deploy Preview https://deploy-preview-4792--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rainerhahnekamp rainerhahnekamp self-requested a review May 25, 2025 10:08
Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I left two comments for tiny changes.

@markostanimirovic markostanimirovic added the Needs Cleanup Review changes needed label May 28, 2025
@markostanimirovic markostanimirovic removed the Needs Cleanup Review changes needed label May 29, 2025
@markostanimirovic markostanimirovic changed the title feat(signals): expose a writable state in withFeature fix(signals): expose WritableStateSource to withFeature callback May 29, 2025
Copy link
Contributor

@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @GuillaumeNury! 👍

@markostanimirovic markostanimirovic merged commit afb6528 into ngrx:main May 29, 2025
14 checks passed
@markostanimirovic
Copy link
Member

Thanks @GuillaumeNury!

@GuillaumeNury
Copy link
Contributor Author

@rainerhahnekamp @markostanimirovic you're welcome! Thank you for the rebase and the fix. Sorry I was off for some days 🙈

@rainerhahnekamp
Copy link
Contributor

All good @GuillaumeNury. We managed to do the last steps on our own 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add STATE_SOURCE to store provided by withFeature
3 participants