Skip to content

feat(www): add sidebar for mobile view and make home page responsive #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025

Conversation

DuskoPeric
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Home page and side menu are not responsive for small screens

Closes #4807

What is the new behavior?

Home page and side menu are responsive for small screens

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 49472cc
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/6840c1c1a609ae0008f6dce5

Copy link

netlify bot commented Jun 3, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 49472cc
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/6840c1c1ec01b500088d8bf9
😎 Deploy Preview https://deploy-preview-4813--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markostanimirovic markostanimirovic changed the title fix(www): Home page and side menu responsive feat(www): add sidebar for mobile view and make home page responsive Jun 4, 2025
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine on the homepage, but on other pages the new design cuts of the title, e.g. at https://deploy-preview-4813--ngrx-site-v19.netlify.app/guide/store/why

Do you think we can fix this as well?

image

@markostanimirovic
Copy link
Member

@timdeschryver

I opened issues for other pages: #4816 #4817

@timdeschryver timdeschryver merged commit 4397bfb into ngrx:main Jun 5, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Docs] Make Homepage Responsive
3 participants